feat: Add streaming notification stubs for standalone mode - #642
feat: Add streaming notification stubs for standalone mode#642kalyanpullela wants to merge 1 commit into
Conversation
Add stub implementations for 9 streaming notification methods: - SwitchStateChangeNotification - SwitchShutdownRequestNotification - FdbEventNotification - PortStateChangeNotification - PacketEventNotification - QueuePfcDeadlockNotification - BfdSessionStateChangeNotification - TamEventNotification - IpsecSaStatusChangeNotification All return UNIMPLEMENTED as streaming is not supported in standalone mode.
|
/gcbrun |
|
Hi Kalyan, Did you use this saiserver for any testing? |
Hi Sonika, yes this was used to bypass an error that was caused about 7 seconds after RemoveSwitch was completed. |
Is this a reply to: https://github.com/openconfig/lemming/pull/641/changes#r2743016059 ? |
Actually, I just went back and double checked the work. PR 641 is a mistake. But this pr is required to ensure that I don't run into issues during remove switch. |
AFAIK, this standalone cc saiserver is not used in AlpineVS image (libsaigrpc uses https://github.com/openconfig/lemming/tree/main/dataplane/standalone/sai) or in Lucius (it uses the go server: https://github.com/openconfig/lemming/tree/main/dataplane/saiserver). Thats why I am wondering how did you use this standalone mode? |
Oh that makes sense, the standalone saiserver isn't brought up at all. I think while looking for causes of fault for RemoveSwitch issue, I might have made modifications to this file. |
2 participants
Add stub implementations for 9 streaming notification methods:
All return UNIMPLEMENTED as streaming is not supported in standalone mode.